Skip to content

df: Add a mount_dev_id to use id's instead of paths #10198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
van-sprundel wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

df: Add a mount_dev_id to use id's instead of paths #10198

van-sprundel wants to merge 1 commit into from
+43 −3

Conversation

@van-sprundel
Copy link
Contributor

@van-sprundel van-sprundel commented Jan 12, 2026 •
edited
Loading

I thought this would be an easier fix, but there's a lot that I did not understand from system file mounts. For example, what "over mounting" is and when a file system is over mounted.

ramones@fedora:~/git/coreutils$ diff <(df --all 2>/dev/null | sort) <(./target/release/df --all 2>/dev/null | sort) | head -20
20,21d19
< nsfs                   -         -         -    - /run/docker/netns/f28327792c0d
< overlay                -         -         -    - /var/lib/docker/overlay2/852ac0d36c2d3d13e4bcf9aad8d58cbb182c2b3ba289671e36138b7ce86ed7c2/merged
27c25
< systemd-1              -         -         -    - /proc/sys/fs/binfmt_misc
---
> systemd-1              0         0         0    - /proc/sys/fs/binfmt_misc
ramones@fedora:~/git/coreutils$ ./target/release/df --all 2>/dev/null | grep binfmt_misc
systemd-1              0         0         0    - /proc/sys/fs/binfmt_misc
binfmt_misc            0         0         0    - /proc/sys/fs/binfmt_misc

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from becb0ee to 990f378 Compare January 12, 2026 09:06
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from 990f378 to 02a706e Compare January 12, 2026 16:55
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch 2 times, most recently from 990f378 to f32abb3 Compare January 12, 2026 17:45
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from f32abb3 to 7faf1db Compare January 12, 2026 18:22
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch 4 times, most recently from dd80c03 to 1efd049 Compare January 12, 2026 21:50
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from 1efd049 to a59f495 Compare January 13, 2026 08:30
@van-sprundel
Copy link
Contributor Author

van-sprundel commented Jan 13, 2026 •
edited
Loading

Seems like this test keeps failing due to no space left when cleaning up. Not sure if I can do something about this

https://github.com/uutils/coreutils/actions/runs/20926906984/job/60127207847

ah its not just me

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from a59f495 to 8daf10a Compare January 13, 2026 16:33
@sylvestre
Copy link
Contributor

sylvestre commented Jan 17, 2026

is it still a draft ? thanks

@van-sprundel
Copy link
Contributor Author

van-sprundel commented Jan 18, 2026

is it still a draft ? thanks

Yes, in hindsight I'm still not a fan of this impl. Maybe this logic should be more higher up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@van-sprundel @sylvestre